[Crypto] Improve Event.getClearContent() and fix assignement issue.#8744
Merged
Conversation
…pted content when the content is not decrypted.
This may fix issue of Event not decrypted if the key is coming late for the last Event displayed in the Room list.
BillCarsonFr
approved these changes
Feb 1, 2024
| val roomId = content.sessionId ?: return@forEach | ||
| val sessionId = content.sessionId | ||
|
|
||
| val roomId = content.roomId |
Member
Author
|
There is a failing test |
…ted Event, and it is null in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
The first commit should prevent encrypted content to be parsed as decoded Event. Hopefully there will be no side effect. I have checked and this should be fine.
The last commit is fixing an issue, calling
RoomService.refreshJoinedRoomSummaryPreviewshas never worked as expected with the Crypto Rust SDK.Motivation and context
Should fix lots of error logs when undecrypted Events content are mapped to Content model.
Screenshots / GIFs
Tests
Tested devices
Checklist