Change targetApi to 35 by bmarty · Pull Request #9051 · element-hq/element-android

bmarty · 2025-07-08T08:20:45Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Change the targetSdk to 35.
Also update the gradle plugin and the lint version.
Some enforcement has been done to check for permission.
Also edgeToEdge is enabled by default now.
Reviewer should test carefully the screens on various devices. Probably good to let this code on the nightly / open testing for an extra days.

Motivation and context

Be able to publish the application on the PlayStore in september 2025.

Closes #9049

Screenshots / GIFs

Tests

Smoke test, the screens should render correctly on all OS versions

Tested devices

Physical API 35
Emulator API 30
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

./gradlew wrapper --gradle-version 8.14.3 --gradle-distribution-sha256-sum bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531

sonarqubecloud · 2025-07-08T13:28:01Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

ElementBot · 2025-07-11T18:09:09Z

	Warnings
⚠️	gradle.properties#L45 - Newer version of lint available: 8.12.0-alpha09
⚠️	gradle.properties#L45 - Newer version of lint available: 8.12.0-alpha09
⚠️	library/attachment-viewer/src/main/java/im/vector/lib/attachmentviewer/AttachmentViewerActivity.kt#L114 - Custom view `FrameLayout` has `setOnTouchListener` called on it but does not override `performClick`
⚠️	library/attachment-viewer/src/main/java/im/vector/lib/attachmentviewer/AttachmentViewerActivity.kt#L114 - Custom view `FrameLayout` has `setOnTouchListener` called on it but does not override `performClick`
⚠️	vector/src/main/AndroidManifest.xml#L16 - READ_EXTERNAL_STORAGE is deprecated (and is not granted) when targeting Android 13+. If you need to query or interact with MediaStore or media files on the shared storage, you should instead use one or more new storage permissions: `READ_MEDIA_IMAGES`, `READ_MEDIA_VIDEO` or `READ_MEDIA_AUDIO`.
⚠️	vector/src/main/AndroidManifest.xml#L16 - READ_EXTERNAL_STORAGE is deprecated (and is not granted) when targeting Android 13+. If you need to query or interact with MediaStore or media files on the shared storage, you should instead use one or more new storage permissions: `READ_MEDIA_IMAGES`, `READ_MEDIA_VIDEO` or `READ_MEDIA_AUDIO`.
⚠️	vector/src/main/AndroidManifest.xml#L185 - This intent filter has the format of an Android App Link but is missing the `autoVerify` attribute; add `android:autoVerify="true"` to ensure your domain will be validated and enable App Link-related Lint warnings. If you do not want clicked URLs to bring the user to your app, remove the `android.intent.category.BROWSABLE` category, or set `android:autoVerify="false"` to make it clear this is not intended to be an Android App Link.
⚠️	vector/src/main/AndroidManifest.xml#L185 - This intent filter has the format of an Android App Link but is missing the `autoVerify` attribute; add `android:autoVerify="true"` to ensure your domain will be validated and enable App Link-related Lint warnings. If you do not want clicked URLs to bring the user to your app, remove the `android.intent.category.BROWSABLE` category, or set `android:autoVerify="false"` to make it clear this is not intended to be an Android App Link.
⚠️	vector/src/main/AndroidManifest.xml#L194 - Attribute `autoVerify` is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L194 - Attribute `autoVerify` is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L209 - Attribute `autoVerify` is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L209 - Attribute `autoVerify` is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L239 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L239 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L242 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L242 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L296 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L296 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L296 - Fixed screen orientations will be ignored in most cases, starting from Android 16. Android is moving toward a model where apps are expected to adapt to various orientations, display sizes, and aspect ratios.
⚠️	vector/src/main/AndroidManifest.xml#L296 - Fixed screen orientations will be ignored in most cases, starting from Android 16. Android is moving toward a model where apps are expected to adapt to various orientations, display sizes, and aspect ratios.
⚠️	vector/src/main/AndroidManifest.xml#L305 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L305 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L312 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L312 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L318 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L318 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L447 - Exported receiver does not require permission
⚠️	vector/src/main/AndroidManifest.xml#L447 - Exported receiver does not require permission
⚠️	vector/src/main/java/im/vector/app/features/notifications/NotificationUtils.kt#L1072 - Use the KTX function `createBitmap` instead?
⚠️	vector/src/main/java/im/vector/app/features/notifications/NotificationUtils.kt#L1072 - Use the KTX function `createBitmap` instead?
⚠️	vector/src/main/java/im/vector/app/features/webview/VectorWebViewActivity.kt#L46 - Using `setJavaScriptEnabled` can introduce XSS vulnerabilities into your application, review carefully
⚠️	vector/src/main/java/im/vector/app/features/webview/VectorWebViewActivity.kt#L46 - Using `setJavaScriptEnabled` can introduce XSS vulnerabilities into your application, review carefully
⚠️	vector/src/main/res/layout/activity_call.xml#L10 - Possible overdraw: Root element paints background `@color/bg_call_screen_blur` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/activity_call.xml#L10 - Possible overdraw: Root element paints background `@color/bg_call_screen_blur` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/activity_progress.xml#L6 - Possible overdraw: Root element paints background `?vctr_waiting_background_color` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/activity_progress.xml#L6 - Possible overdraw: Root element paints background `?vctr_waiting_background_color` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/fragment_generic_recycler.xml#L8 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/fragment_generic_recycler.xml#L8 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)

Generated by 🚫 dangerJS against f421ead

… have the problem, not sure why :/)

…vities." This reverts commit 3d7bf51.

jmartinesp

LGTM!

jmartinesp · 2025-07-16T14:30:18Z

...y/attachment-viewer/src/main/java/im/vector/lib/attachmentviewer/AttachmentViewerActivity.kt

            window.decorView.windowInsetsController?.systemBarsBehavior = WindowInsetsController.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
            // New API instead of FLAG_TRANSLUCENT_STATUS
+            @Suppress("DEPRECATION")
            window.statusBarColor = ContextCompat.getColor(this, R.color.half_transparent_status_bar)


At some point we should move these colors to enableEdgeToEdge I think. We can probably wait until it's mandatory though.

bmarty added 7 commits July 7, 2025 17:30

Set compileSdk and targetSdk to 35

8a9a699

Fix compilation issue.

a283eea

Upgrade Android Gradle Plugin to 8.11.0

3652ae5

Update gradle wraaper using command line

390ae56

./gradlew wrapper --gradle-version 8.14.3 --gradle-distribution-sha256-sum bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531

Update lint version

da983b4

Update gradle wraaper using command line

06721da

./gradlew wrapper --gradle-version 8.14.3 --gradle-distribution-sha256-sum bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531

Supress deprecation warning.

78e100d

bmarty added 7 commits July 9, 2025 13:02

Fix lint warning

6e56c38

Fix lint warning

27fc09b

Fix lint warning: ignore impossible SecurityException

cf01890

Fix lint warning: check permission before notifying with notification

de3874e

Fix lint warning: check permission before using location API

fd67cac

Fix lint warning: check permission before recording audio

e562208

A final period.

1d08018

bmarty added 7 commits July 15, 2025 11:14

Avoid crash for long logs.

9b0d22f

Target API 35: set android:fitsSystemWindows="true" to Activities.

3d7bf51

Remove dead code.

0a69a33

Fix UI issue

58de848

Remove useless margin

66ec110

Fix color issue on HomeActivity and RoomDetailActivity (others do not…

82317bf

… have the problem, not sure why :/)

Fix regression on timeline for thread.

3f22ddb

bmarty force-pushed the feature/bma/target35 branch from 83cf66c to 3f22ddb Compare July 16, 2025 09:49

bmarty and others added 3 commits July 16, 2025 12:52

Revert "Target API 35: set android:fitsSystemWindows="true" to Acti…

daadbbd

…vities." This reverts commit 3d7bf51.

Enable edgeToEdge

c79f2ff

Fix issue in timeline screen.

89b1034

bmarty marked this pull request as ready for review July 16, 2025 14:12

jmartinesp approved these changes Jul 16, 2025

View reviewed changes

Code cleanup

f421ead

bmarty merged commit ee64466 into develop Jul 17, 2025
12 of 16 checks passed

bmarty deleted the feature/bma/target35 branch July 17, 2025 13:11

Benjamin-Loison mentioned this pull request Sep 14, 2025

*The application has crashed* on approximately a daily basis, due to *Time limit already exhausted for foreground service type dataSync*, hence do not receive background notifications most of time Benjamin-Loison/element-android#53

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change targetApi to 35#9051

Change targetApi to 35#9051
bmarty merged 25 commits intodevelopfrom
feature/bma/target35

bmarty commented Jul 8, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Jul 8, 2025

Uh oh!

ElementBot commented Jul 11, 2025 •

edited

Loading

Uh oh!

jmartinesp left a comment

Uh oh!

jmartinesp Jul 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bmarty commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

sonarqubecloud bot commented Jul 8, 2025

Quality Gate failed

Uh oh!

ElementBot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmartinesp left a comment

Choose a reason for hiding this comment

Uh oh!

jmartinesp Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bmarty commented Jul 8, 2025 •

edited

Loading

ElementBot commented Jul 11, 2025 •

edited

Loading