Do not end call with error in case of MediaDeviceError#3688
Merged
BillCarsonFr merged 1 commit intolivekitfrom Jan 19, 2026
Merged
Do not end call with error in case of MediaDeviceError#3688BillCarsonFr merged 1 commit intolivekitfrom
BillCarsonFr merged 1 commit intolivekitfrom
Conversation
BillCarsonFr
added
the
PR-Task
toger5
approved these changes
Jan 19, 2026
Contributor
toger5
left a comment
toger5
left a comment
There was a problem hiding this comment.
Thanks valere. I am sad and sorry on the not doable tests...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regressions after CallViewModel refactoring
#Fixes https://github.com/element-hq/voip-internal/issues/440 - Call ends with error if try to enable camera when permission was denied
#Fixes https://github.com/element-hq/voip-internal/issues/439 - Call ends with error if user cancel sceensharing at the window selection screen.
I tried to do some playwright test for that, but could not find a way to Deny a permission.
It is possible to not grant a permission, but when doing that the playwright browser is in an intermediate state where the permission is nor granted nor denied. Thus it is not possible to reproduce :/
Maybe this could have helped? microsoft/playwright#6488 but it was closed