Make sdk build compatible with content loaded action#3773
Open
toger5 wants to merge 1 commit intoelement-hq:livekitfrom
Open
Make sdk build compatible with content loaded action#3773toger5 wants to merge 1 commit intoelement-hq:livekitfrom
toger5 wants to merge 1 commit intoelement-hq:livekitfrom
Conversation
toger5
added
the
PR-Improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a lost branch which was done in the context of the FOSDEM demo.
Adding a PR so we dont lose it.
If this is not set widget setup for waitForIFrameLoaded=false will never start. And waitForIFrameLoaded=true might lead to races on widget startup...
So the only good way to do this is
waitForIFrameLoaded=falseso we needsendContentLoaded(we do the same for element call anyways)