feat: show call member presence in pre-join lobby view#3803
Open
alex-vg wants to merge 1 commit intoelement-hq:livekitfrom
Open
feat: show call member presence in pre-join lobby view#3803alex-vg wants to merge 1 commit intoelement-hq:livekitfrom
alex-vg wants to merge 1 commit intoelement-hq:livekitfrom
Conversation
Display participant avatars with display names in the lobby when a call is already active. Shows up to 8 avatars with an overflow indicator and tooltip for additional participants. - Add useCallParticipants hook to derive participants from memberships - Add CallParticipantRow component using Compound Tooltip and Radix VisuallyHidden for accessibility - Integrate into LobbyView above VideoPreview - Include unit tests for hook and component - Add i18n strings for participant count and overflow
|
|
|
fixes: #2385 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display participant avatars with display names in the lobby when a call is already active, so users can see who's in the call before joining.
Changes
useCallParticipantshook — derives a deduplicated participant list with resolved display names and avatar URLs fromMatrixRTCSession.memberships+RoomCallParticipantRowcomponent — renders up to 8 participant avatars in a horizontal row. Overflow participants are shown as a+Nindicator with a Compound<Tooltip>listing the remaining names. Uses Radix<VisuallyHidden>for screen reader accessibility.LobbyViewintegration — the participant row appears above theVideoPreviewwhencallParticipants.length > 0GroupCallView— calls the hook and passes participants toLobbyViewRoomPage— passescallParticipants={[]}in the knock/waitForInvite state (user can't see room members)Testing
useCallParticipantsCallParticipantRowScreenshots
The participant row appears above the video preview in the lobby when another user is already in the call.
