Conversation
6 tasks
Member
|
Ah but will need a changelog of course :) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7991 +/- ##
========================================
Coverage 16.96% 16.97%
========================================
Files 1766 1766
Lines 122112 122110 -2
Branches 49184 49183 -1
========================================
+ Hits 20719 20726 +7
+ Misses 100717 100710 -7
+ Partials 676 674 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Depends on matrix-ios-sdk branch. n.b. this still doesn't implement the SSO redirect parameter as described for MSC3824: > - append action=login and action=register parameters to the SSO redirect URLs
pixlwave
force-pushed
the
hughns/oauth-stable
branch
from
591d67c to
4ea0e5f
Compare
Member
|
I've also included a small fix for the sunset banners in here too (I guess something else changed in the configuration between now and when we tested these against beta.matrix.org). And there's a fix for the UI tests in #7994. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-ios-sdk#1917.
Fixes #7925
n.b. this still doesn't implement the SSO redirect parameter as described for MSC3824:
Pull Request Checklist