Batch outbound device list poke replication notifications#19529
Open
Batch outbound device list poke replication notifications#19529
Conversation
Move notify_replication() and send_device_messages() from inside the per-row loop to after each batch of room-poke conversions. This allows the outbound pokes to be coalesced into fewer RDATA messages by the deduplication in DeviceListsStream._update_function, rather than trickling out one at a time.
MadLittleMods
approved these changes
Mar 5, 2026
Comment on lines
-1148
to
-1154
| hosts, immediate=False | ||
| ) | ||
| # TODO: when called, this isn't in a logging context. | ||
| # This leads to log spam, sentry event spam, and massive | ||
| # memory usage. | ||
| # See https://github.com/matrix-org/synapse/issues/12552. | ||
| # log_kv( |
Contributor
There was a problem hiding this comment.
Removed because we don't care about it anymore?
If this is the case, we should close #12559 (previously matrix-org/synapse#12559) (linked from matrix-org/synapse#12552)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
notify_replication()andsend_device_messages()from inside the per-row loop to after each batch of room-poke conversions. This allows the outbound pokes to be coalesced into fewer RDATA messages by the deduplication inDeviceListsStream._update_function(see #19528), rather than trickling out one at a time.Follow up from #19528