Skip to content

Prevent sending registration emails if registration is disabled#19585

Merged
anoadragon453 merged 2 commits intodevelopfrom
anoa/require_email_flow_to_send_email
Mar 19, 2026
Merged

Prevent sending registration emails if registration is disabled#19585
anoadragon453 merged 2 commits intodevelopfrom
anoa/require_email_flow_to_send_email

Conversation

@anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Mar 18, 2026

Partially addresses #19477

Closes a loophole in sending emails related to registration, in which Synapse would send registration emails even if registration was disabled (reported here).

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@anoadragon453 anoadragon453 marked this pull request as ready for review March 18, 2026 13:16
@anoadragon453 anoadragon453 requested a review from a team as a code owner March 18, 2026 13:16
@MadLittleMods MadLittleMods added A-3PID Issues affecting third-party identifiers and invites A-Registration labels Mar 18, 2026
@anoadragon453 anoadragon453 merged commit 9edbf56 into develop Mar 19, 2026
46 checks passed
@anoadragon453 anoadragon453 deleted the anoa/require_email_flow_to_send_email branch March 19, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-3PID Issues affecting third-party identifiers and invites A-Registration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants