Reinstate removed EventBase methods#19712
Merged
Merged
Conversation
Both `__getitem__` and `.user_id` were removed in #19680 to simplify the event class. However, `EventBase` is exposed to modules who might also make use of those methods, so let's reinstate them (but otherwise not reinstate the usage of them in the code).
reivilibre
approved these changes
Apr 21, 2026
Contributor
reivilibre
left a comment
reivilibre
left a comment
There was a problem hiding this comment.
SGTM but we could annotate the deprecation better for external users to be more aware of it
Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
__getitem__and.user_idwere removed in #19680 to simplify the event class. However,EventBaseis exposed to modules who might also make use of those methods, so let's reinstate them (but otherwise not reinstate the usage of them in the code).