Skip to content

Revert "Send a SSS response immediately if the config has changed and there are new results to sync (#19714)"#19784

Merged
reivilibre merged 2 commits into
developfrom
rei/revert_19714
May 15, 2026
Merged

Revert "Send a SSS response immediately if the config has changed and there are new results to sync (#19714)"#19784
reivilibre merged 2 commits into
developfrom
rei/revert_19714

Conversation

@reivilibre
Copy link
Copy Markdown
Contributor

Reverts: #19714

Opens: #19783

Closes: https://github.com/element-hq/backend-internal/issues/242

Related: #18880 (the performance problem that is aggravated by #19714)

  1. Revert "Send a SSS response immediately if the config has changed and there are new results to sync (Send a SSS response immediately if the config has changed and there are new results to sync #19714)"
    This reverts commit 2691d0b.

… there are new results to sync (#19714)"

This reverts commit 2691d0b.
@reivilibre reivilibre changed the title Revert Have [MSC4186: Simplified Sliding Sync](https://github.com/matrix-org/matrix-spec-proposals/pull/4186) return a new response immediately if a room subscription has changed and produced a new response. ([\#19714](https://github.com/element-hq/synapse/issues/19714)) due to performance problems. Revert "Send a SSS response immediately if the config has changed and there are new results to sync (#19714)" May 14, 2026
Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
@reivilibre reivilibre marked this pull request as ready for review May 14, 2026 16:32
@reivilibre reivilibre requested a review from a team as a code owner May 14, 2026 16:32
@erikjohnston
Copy link
Copy Markdown
Member

The plan is to reintroduce this PR and a fix for the underlying issue in the next Synapse version.

@reivilibre reivilibre enabled auto-merge (squash) May 14, 2026 16:41
@reivilibre reivilibre merged commit 3f0f03d into develop May 15, 2026
78 of 81 checks passed
@reivilibre reivilibre deleted the rei/revert_19714 branch May 15, 2026 10:36
reivilibre added a commit that referenced this pull request May 15, 2026
… there are new results to sync (#19714)" (#19784)

Reverts: #19714

Opens: #19783

Closes: element-hq/backend-internal#242

Related: #18880 (the performance problem that is aggravated by #19714)

This reverts commit 2691d0b.

---------

Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants