Add text query support#761
Merged
greg-rychlewski merged 5 commits intoelixir-ecto:masterfrom Feb 1, 2026
Merged
Conversation
josevalim
approved these changes
Feb 1, 2026
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
I am very happy to ship it as is. If you don't want to do query_many, you just need to remove TextQueries :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #757
We didn't discuss this so I'm completely ok discarding it if the decision is to not add it.
The idea came from a google group message here: https://groups.google.com/g/elixir-ecto/c/mooS_UwcuwU. Basically they are trying to use Postgres's explain generic plan statement (e.g.
EXPLAIN (GENERIC_PLAN) SELECT * FROM pg_class WHERE relname = $1;) but it does not play nice with the binary protocol because it thinks you need to supply $1 instead of it just being a signal that it's a generic query that you want explained.Aside from the one specific use case, they also mentioned they are using livebook. And that got me thinking it might be cool to be able to use livebook like an alternative to psql where you can just type in your queries and not worry about binary types and extensions and all that.
I didn't add query_many because it's a bit weird and I would have to think about the implementation. The reason it's weird is because it would only work for the text protocol. So I didn't want to think of a solution if we will not go this direction at all.