Fix prefixing unused variables with underscore#778
Closed
sheldak wants to merge 2 commits intoelixir-lsp:masterfrom
Closed
Fix prefixing unused variables with underscore#778sheldak wants to merge 2 commits intoelixir-lsp:masterfrom
sheldak wants to merge 2 commits intoelixir-lsp:masterfrom
Conversation
| |> SourceFile.lines() | ||
| |> Enum.at(start_line) | ||
|
|
||
| pattern = Regex.compile!("(?<![[:alnum:]._])#{variable}(?![[:alnum:]._])") |
Collaborator
There was a problem hiding this comment.
use Regex.escape/1 on variable. Elixir variables can have non regex friendly chars !?.
Collaborator
|
Thanks for the PR but this will need to be solved properly by AST manipulation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I noticed some issues with this feature and an attempt to revert it (#775), I would like to propose a fix that hopefully makes it more usable.
Instead of adding
_at the beginning of the line, I would replace the unused variablevarwith_varusingString.replace/4with the following regex:"(?<![[:alnum:]._])#{variable}(?![[:alnum:]._])"I assume the unused variable does not have any of
._as a prefix or suffix.
Also, to prevent replacing incorrectly in the cases like:
I'm not creating a quickfix if there is more than one match in the line.