#add-nested-types Nested types has been added#70
Open
AKAlexsey wants to merge 1 commit intoelixir-soap:masterfrom
Open
#add-nested-types Nested types has been added#70AKAlexsey wants to merge 1 commit intoelixir-soap:masterfrom
AKAlexsey wants to merge 1 commit intoelixir-soap:masterfrom
Conversation
Author
|
Hello. I have faced to some problem. If some of passed parameters belongs to not primitive type, there is error: It happens because here http://joxi.ru/KAxJ1JDHZ8Mv6m you don't check if value is complex type. |
Member
|
Hi @CarefreeSlacker. |
Nitrino
approved these changes
May 31, 2019
Member
Nitrino
left a comment
There was a problem hiding this comment.
Sorry for the long response.
This is a good improvement and will be merged after fixing the CI.
Member
|
@CarefreeSlacker Can you please fix CI? |
Member
|
And add tests for such case |
|
hi, any update on this pr? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.