Skip to content

Implement inline precompilation.#286

Merged
rwjblue merged 7 commits intoember-cli:masterfrom
rwjblue:add-inline-precompile
Sep 9, 2019
Merged

Implement inline precompilation.#286
rwjblue merged 7 commits intoember-cli:masterfrom
rwjblue:add-inline-precompile

Conversation

@rwjblue
Copy link
Copy Markdown
Member

@rwjblue rwjblue commented Sep 9, 2019

  • Bring initial implementation over from ember-cli-htmlbars-inline-precompile.
  • Refactor to avoid duplication, streamline both .hbs transpilation and inline precompilation
  • Add CI run to ensure there is no conflict with ember-cli-htmlbars-inline-precompile
  • Add smoke tests ensuring that importing from all three known paths works

Allows consumers to use inline precompilation without having
ember-cli-htmlbars-inline-precompile as a dependency. Example usage:

import { hbs } from 'ember-cli-htmlbars';

export default Ember.Component.extend({
  layout: hbs`wheeeee`,
});

Implements ember-cli/ember-cli-htmlbars-inline-precompile#298

@rwjblue rwjblue merged commit e2c8b30 into ember-cli:master Sep 9, 2019
@rwjblue rwjblue deleted the add-inline-precompile branch September 9, 2019 01:33
bors added a commit to rust-lang/crates.io that referenced this pull request Dec 19, 2019
Remove obsolete `ember-cli-htmlbars-inline-precompile` dependency

Since ember-cli/ember-cli-htmlbars#286, the `ember-cli-htmlbars-inline-precompile` dependency is obsolete and replaced by `ember-cli-htmlbars` itself :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant