Use smaller cache key for ember-template-compiler (reduce overall memory overhead of caching)#528
Merged
rwjblue merged 1 commit intoember-cli:masterfrom Apr 27, 2020
Merged
Conversation
xg-wang
force-pushed
the
smaller-cachekey
branch
from
aaccee2 to
2a08085
Compare
rwjblue
requested changes
Apr 21, 2020
xg-wang
force-pushed
the
smaller-cachekey
branch
from
2a08085 to
83ada99
Compare
rwjblue
approved these changes
Apr 27, 2020
rwjblue
changed the title
ember-template-compiler (reduce overall memory overhead of caching)
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole file content string of template compiler is ~700kb, full path
should be enough for cacheKey