Ignore fastboot build output file if app unused/disable fastboot#468
Ignore fastboot build output file if app unused/disable fastboot#468xg-wang merged 6 commits intoember-cli:masterfrom
Conversation
|
btw, i find a related issue : #320 |
xg-wang
left a comment
xg-wang
left a comment
There was a problem hiding this comment.
Thanks, can you add a test similar to https://github.com/ember-cli/ember-fetch/blob/master/test/fastboot-build-test.js?
|
hi, @xg-wang , unit test appended is passed in local dev env , but CI is fail in pull. |
|
@houfeng0923 I think CI fails because node8 doesn't have |
|
sorry, @xg-wang, last commit is passed in unit test, but CI always fail , |
| }); | ||
| }); | ||
|
|
||
| it('build with process.env.FASTBOOT_DISABLED', function() { |
There was a problem hiding this comment.
The default app does not have ember-cli-fastboot, this test needs to install then set the flag to actually test the case.
There was a problem hiding this comment.
i know u meaning, but i think it's a case point in ember fastboot.
but if you think so, case can update .
|
@houfeng0923 the dependency issue is resolved, I tried to push your branch to a fork and ci is passing https://github.com/xg-wang/ember-fetch/runs/533697154 |
xg-wang
changed the title
3 participants
hi @xg-wang :
i am doing work on reducing assets files size for deploy.
there is no ember-cli-fastboot in my project , so can we remove fetch-fastboot file in outputTree ? .