Merged
Conversation
7ed2625 to
2cc2cc1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 21 21
Lines 511 511
=======================================
Hits 488 488
Misses 23 23 ☔ View full report in Codecov by Sentry. |
Member
|
Is the |
Member
Author
|
@bertdeblock no it's not needed any more 👍 I actually have been meaning to remove it upstream 🙈 it's totally not needed any more |
bertdeblock
approved these changes
Dec 23, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mentioned in my previous PR #1038 that I noticed @bertdeblock 's recent work and was looking forward to see a list of changes that will be coming in the next release and which changes were considered breaking.
This PR is moving us to release-plan so that we can have that list before we actually do the release 👍