Add support for npm overrides#850
Merged
kategengler merged 2 commits intoember-cli:masterfrom Mar 23, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 94.36% 94.37% +0.01%
==========================================
Files 17 17
Lines 550 551 +1
==========================================
+ Hits 519 520 +1
Misses 31 31
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Thanks! Can you also add something to the readme about this feature? |
This was referenced May 13, 2022
Member
Author
|
@kategengler yes that would make a lot of sense if I did that 😂 I'm working on this live on my stream so I guess I just overlooked it 🙃 I've added them now 👍 |
ctjhoa
pushed a commit
to concordnow/ember-content-loader
that referenced
this pull request
Jun 6, 2022
Til better fix with ember-cli/ember-try#850
malgasm
added a commit
to dictatelife/ember-cli-dompurify
that referenced
this pull request
Sep 11, 2022
59514eb to
81beb54
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to help with the issue that is described in emberjs/ember-render-modifiers#64
Essentially npm thinks that ranges shouldn't be satisfied if you are using pre-releases. You can overcome this if you use an
overridesin npm which works in a very similar way to yarn resolutions.The issue is that if you provide an
overridesconfig to ember-try it will just ignore it:This PR implements npm overrides in much the same way as yarn resolutions 👍 in fact I copy and pasted all of the resolutions tests and just changed resolutions to overrides in most cases 😂