no-new-mixins being flagged incorrectly

[amk221]

...I tried to write a failing test, but the above code passed :/

[bmish]

What's the file path?

[amk221]

Ohh, is that how you're figuring it out? :(

tests/lib/common/unit/mixins/model/de-dupe.js

[bmish]

Yeah the detection is based on having mixin in the file path and extending an Ember object. Not great, but it also seems a bit confusing that your path has /model/ under the /mixins/ path.

[amk221]

Ok.

I store my mixins in directories like so:

lib/mixins/model
lib/mixins/route
lib/mixins/controller
lib/mixins/component

because I have a lot, I group them by the type of thing they are mixed-in to.

...hence my need for this rule. I do not want any more new mixins :)

Do you have any suggestions for me other than renaming the directories (which I don't want to do).

[bmish]

You can disable the rule in .eslintrc.js for the entire tests directory. Would that help?

[amk221]

I suppose I could do that for the time being 🙂 But I'd prefer to keep this issue open so that a better solution is found.

(It seems to be a common theme, see here: #235)

Cheers

[alexlafroscia]

A number of the ESLint rules we have use the path on the filesystem to determine what type of class is being defined -- maybe that's something worth avoiding?

We could pretty easily determine if a new Mixin is being defined by tracking the imported identifier back to the @ember/object/mixin module -- maybe that's a change worth making?

[bmish]

I noticed that #213 would help fix this.