Add no-builtin-form-components rule#2282
Merged
NullVoxPopuli merged 2 commits intoember-cli:masterfrom Jul 24, 2025
Merged
Conversation
wagenet
force-pushed
the
no-built-in-form-components
branch
from
7486ea1 to
0e5d7d5
Compare
Contributor
There was a problem hiding this comment.
in order to merge as non-breaking, we can't change the recommended rules
wagenet
commented
Jul 23, 2025
| "no-at-ember-render-modifiers", | ||
| "no-attrs-in-components", | ||
| "no-attrs-snapshot", | ||
| "no-builtin-form-components", |
Contributor
Author
There was a problem hiding this comment.
Hmm... this seems wrong.
NullVoxPopuli
requested changes
Jul 23, 2025
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Can't change recommended configs until a major
Contributor
Author
|
I'll turn it off by default, but for the next major we should definitely turn it on. |
wagenet
force-pushed
the
no-built-in-form-components
branch
from
fbd8612 to
3bee52f
Compare
NullVoxPopuli
approved these changes
Jul 24, 2025
Contributor
|
I've already added it to the list in #2060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle cases in template tag files that were poorly handled by ember-template-lint previously. See also ember-template-lint/ember-template-lint#3155
Docs were written by AI, but seem ok.