fix: Ignore findBy calls from ember-cli-mirage in no-array-prototype-extensions

[VasylMarchuk]

We're trying to fix array prototype extensions usages in our project, and are running into a lot of false positives in our tests when using findBy from ember-cli-mirage:

this.server.schema.courses.findBy({ slug: 'dummy' });
this.server.schema.users.findBy({ username: 'test' });

This adds an exception to lib/rules/no-array-prototype-extensions.js and adjusts the tests.

[bmish]

Why is (window|undefined) part of it? That doesn't seem related to this example.

[VasylMarchuk]

That is how it comes up in eslint-plugin-ember's code that checks for exceptions (here in this file), as window.server... or undefined.server... even though in our tests we use this.server.... I am unsure why.

[VasylMarchuk]

I can change the regexp to just /\.server\.schema\.(.*)\.findBy\(\)/ if it seems more appropriate.

[bmish]

It looks like window / undefined is some artifact of our getName helper that we could probably fix separately. Either way, it's not relevant to us, so let's avoid including it.

[VasylMarchuk]

Done, changed to simply /\.server\.schema\.(.*)\.findBy\(\)/

[bmish]

Thanks!