Add Target Action Support deprecation guide#1410
Add Target Action Support deprecation guide#1410wagenet wants to merge 2 commits intoember-learn:mainfrom
Conversation
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| The `actions` hash on components, controllers, and routes, along with the `send` method, is deprecated. These APIs were primarily used with the now-deprecated `{{action}}` modifier and helper. | ||
|
|
||
| The modern approach is to use standard class methods decorated with the `@action` decorator, and to pass functions directly. |
There was a problem hiding this comment.
speaking of @action -- do we ever update deprecation guides? the recommendation will change once we actually get plain methods working for real
There was a problem hiding this comment.
Wouldn't we just deprecate @action at that point?
There was a problem hiding this comment.
we could -- tho that would be hugely disruptive across the ecosystem, so I think I'd want to wait a smidge.
There was huge resistance to deprecating @action here: emberjs/rfcs#1045 (which the RFC wasn't even proposing)
maybe that'll change once the alternative ships
There was a problem hiding this comment.
Yes, we could just updated the deprecation guide. That's why we have them on a website rather than in the code.
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
3 participants
RFC: emberjs/rfcs#1041