Draft: [EmberData] Update guides to suggest include to be an array#2048
Open
Baltazore wants to merge 1 commit intoember-learn:masterfrom
Open
Draft: [EmberData] Update guides to suggest include to be an array#2048Baltazore wants to merge 1 commit intoember-learn:masterfrom
Baltazore wants to merge 1 commit intoember-learn:masterfrom
Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Baltazore
changed the title
3 tasks
gitKrystan
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of discussion in warp-drive-data/warp-drive#9502 we found that there was a long-lasting miss-understanding of
includeparam type definition. As more and more people using TS, we need to fix it, as the type forincludewould be array only, not a string.So this PR aims to correct guides and docs to suggest user to use
includevalue as an array.