More progress removing prototype extensions

[RobbieTheWagner]

Description

Screenshots

[patricklx]

it looks like computed.x are incompatible with tracked array. e.g. computed.and in controllers/promise-tree.js.

[RobbieTheWagner]

it looks like computed.x are incompatible with tracked array. e.g. computed.and in controllers/promise-tree.js.

@patricklx I am not sure I understand. What is the fix here? I do not see tracked arrays in that controller.

[patricklx]

it looks like computed.x are incompatible with tracked array. e.g. computed.and in controllers/promise-tree.js.

@patricklx I am not sure I understand. What is the fix here? I do not see tracked arrays in that controller.

The model is a tracked array. The fix is to use getters instead of computed

[RobbieTheWagner]

@patricklx I updated, but it's got a new error Global error: Uncaught Error: Assertion Failed: EmberObject.create no longer supports defining computed properties. Define computed properties using extend() or reopen() before calling create()

Removing the computed.filter fixes that, but then the test still fails. I was not sure what we wanted to do here.

[patricklx]

computed.filter should also be replaced with getter.
I think the issue is in models/promise . There is a custom decorator which returns a computed

[RobbieTheWagner]

@patricklx do you mean dateComputed? Do you know how we would fix it?

[RobbieTheWagner]

@patricklx do you think this is good to merge now or did you see anything else we needed to tweak?

[patricklx]

@patricklx do you think this is good to merge now or did you see anything else we needed to tweak?

there are still some errors like assembler.find(...).get is not a function, not sure if its releated to prototype extension

[RobbieTheWagner]

@patricklx yeah, this PR is not meant to fix all errors, just a stepping stone.