Skip to content

fix for chrome bfcache#2640

Merged
RobbieTheWagner merged 1 commit intoemberjs:mainfrom
patricklx:always-include-tab-id
Jun 11, 2025
Merged

fix for chrome bfcache#2640
RobbieTheWagner merged 1 commit intoemberjs:mainfrom
patricklx:always-include-tab-id

Conversation

@patricklx
Copy link
Collaborator

@patricklx patricklx commented May 20, 2025

chrome can stop the page at any time and put it into the cache. background script will be stopped, then the tabid will get lost.
before there was a one-time setup to pass the tabId. but that will not work anymore.

https://developer.chrome.com/blog/bfcache-extension-messaging-changes

@patricklx patricklx changed the title always include tab id fix for chrome bfcache May 25, 2025
@patricklx patricklx requested a review from RobbieTheWagner May 25, 2025 08:13
@git-online-helper git-online-helper bot force-pushed the always-include-tab-id branch from ab3dade to c010193 Compare June 6, 2025 14:53
chrome can stop the page at any time and put it into the cache.
then the tabid will get lost
@patricklx patricklx force-pushed the always-include-tab-id branch from c010193 to 64abace Compare June 6, 2025 14:54
@patricklx patricklx added the bug label Jun 6, 2025
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobbieTheWagner RobbieTheWagner merged commit 3844854 into emberjs:main Jun 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants