move build of ember-debug to rollup#2645
Merged
mansona merged 8 commits intoemberjs:mainfrom Jun 11, 2025
Merged
Conversation
15277e0 to
82daeb0
Compare
Contributor
|
@mansona A suggestion of description that you're free to modify 😇 🙏 Done ✅ |
82daeb0 to
a2a1b23
Compare
Contributor
|
Following the rebase, we now have to fix an issue with these lines: |
BlueCutOfficial
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The ember-inspector codebase is structured by two main pieces: the UI app (what you see when you use the inspector extension), and the ember_debug folder (code that is built then bundled into an
ember_debug.jsscript, then injected in the page at runtime to create the bridge between the Ember app you want to inspect and the inspector extension).Description
As part of the ultimate goal of Ember+Vite apps support, this PR changes the way ember_debug folder is built.
ember_debug.jsbundle (this will be reworked in a later PR).Ultimately we will need the injected script to be type=module to be able to use the required top-level await() to support Vite, but for now we can keep it as AMD but move the build over to Rollup.
This change should not be breaking in any way so any regressions are unexpected 👍