Skip to content

fix service detection#2664

Merged
RobbieTheWagner merged 4 commits intoemberjs:mainfrom
patricklx:improve-service-detection
Jul 1, 2025
Merged

fix service detection#2664
RobbieTheWagner merged 4 commits intoemberjs:mainfrom
patricklx:improve-service-detection

Conversation

@patricklx
Copy link
Collaborator

@patricklx patricklx commented Jun 24, 2025

Description

The current code in object-inspector.js doesn't fit well how Services can be detected in the versions we support. Part of the code is now unused, and services appear in the inspector as Computed Properties.

this does the service detection by checking the value after obtaining the value

based on #2661

Screenshots

before:
image

after
image

@patricklx patricklx force-pushed the improve-service-detection branch from ea5db94 to 1dc29ce Compare June 24, 2025 09:45
@patricklx patricklx changed the title Improve service detection improve service detection Jun 24, 2025
@patricklx patricklx force-pushed the improve-service-detection branch 7 times, most recently from e3b3254 to cd5a242 Compare June 24, 2025 19:45
@BlueCutOfficial
Copy link
Contributor

BlueCutOfficial commented Jun 25, 2025

Hey, I would have a request about the PR description 😇

  • Before explaining the change you've done, could you add a sentence to describe the problem and why that change was needed, I suggest something like:

"The current code in object-inspector.js doesn't fit well how Services can be detected in the versions we support. Part of the code is now unused, and services appear in the inspector as Computed Properties."

  • I think this PR would also deserve 2 tiny screenshots before / after, just the part where we can see clearly the C that turned into an S in the fixed version.

EDIT: Also, is it an enhancement? or should we rather label it bug? the current behavior on main looks rather unexpected to me.

@patricklx patricklx force-pushed the improve-service-detection branch from cd5a242 to 8012633 Compare June 25, 2025 09:41
@patricklx patricklx added bug and removed enhancement labels Jun 25, 2025
@patricklx patricklx changed the title improve service detection fix service detection Jun 25, 2025
@patricklx patricklx force-pushed the improve-service-detection branch from 8012633 to 14ea8f5 Compare June 25, 2025 12:48
@patricklx patricklx force-pushed the improve-service-detection branch from 14ea8f5 to 8832374 Compare June 25, 2025 12:50
Co-authored-by: Robbie Wagner <rwwagner90@gmail.com>
@RobbieTheWagner RobbieTheWagner merged commit e8dd6fa into emberjs:main Jul 1, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants