Merged
Conversation
ea5db94 to
1dc29ce
Compare
e3b3254 to
cd5a242
Compare
Contributor
|
Hey, I would have a request about the PR description 😇
"The current code in
EDIT: Also, is it an enhancement? or should we rather label it bug? the current behavior on |
cd5a242 to
8012633
Compare
8012633 to
14ea8f5
Compare
14ea8f5 to
8832374
Compare
Co-authored-by: Robbie Wagner <rwwagner90@gmail.com>
RobbieTheWagner
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current code in object-inspector.js doesn't fit well how Services can be detected in the versions we support. Part of the code is now unused, and services appear in the inspector as Computed Properties.
this does the service detection by checking the value after obtaining the value
based on #2661
Screenshots
before:

after
