Open
Conversation
patricklx
force-pushed
the
add-vite-app
branch
2 times, most recently
from
d406b5b to
e7f961b
Compare
RobbieTheWagner
approved these changes
Jun 26, 2025
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
LGTM! @mansona mind taking a look at this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
based on #2665
this adds a vite test app, with which we can test if ember debug can work with it once with have correct integration.
Currently this uses the workaround mentioned in #2612
see https://github.com/emberjs/ember-inspector/pull/2666/files#diff-8e8f9e09dc6186fb011afbb145595aaf7f3e5ca289f84de2b0350343f7a321a2
when we have better integration we should be able to remove it.
Screenshots