Skip to content

Achieve centralizing imports from Ember#2669

Merged
mansona merged 3 commits intoemberjs:mainfrom
mainmatter:follow-up-cleaning
Jul 16, 2025
Merged

Achieve centralizing imports from Ember#2669
mansona merged 3 commits intoemberjs:mainfrom
mainmatter:follow-up-cleaning

Conversation

@BlueCutOfficial
Copy link
Contributor

@BlueCutOfficial BlueCutOfficial commented Jul 15, 2025

Description

#2668 achieved the centralization of all Ember imports in ember_debug code. However, one developer contributing to the inspector could still implement a new import ember from 'utils/ember'. This is not wanted, and we should highlight it by removing this export, since it's no longer used*.

no longer used*: there was one last forgotten reference to the default Ember export in profile-manager-test. It was removed in favor of the named export used by the test

Additionally, this PR:

  • Fixes a tiny issue with the runloop introduced in Cleanup import ember #2668. We've been a bit fast removing the whole if block since the fallback mechanics is still there.
  • Add a timeout on the GitHub job, because QUnit doesn't timeout correctly. When looking into the no longer used problem above, I had a test stuck for Ember <=3.24, and the CI was on its way to GitHub's default 6-hour timeout.

@BlueCutOfficial BlueCutOfficial marked this pull request as ready for review July 15, 2025 17:28
@BlueCutOfficial BlueCutOfficial requested a review from mansona July 15, 2025 17:46
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic 🎉

@mansona mansona merged commit 33cb2eb into emberjs:main Jul 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants