Achieve centralizing imports from Ember#2669
Merged
mansona merged 3 commits intoemberjs:mainfrom Jul 16, 2025
Merged
Conversation
…on the runloop script
…mber default export
f005c3b to
dd9edf9
Compare
This was referenced Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#2668 achieved the centralization of all Ember imports in
ember_debugcode. However, one developer contributing to the inspector could still implement a newimport ember from 'utils/ember'. This is not wanted, and we should highlight it by removing this export, since it's no longer used*.no longer used*: there was one last forgotten reference to the default Ember export in profile-manager-test. It was removed in favor of the named export used by the test
Additionally, this PR:
ifblock since the fallback mechanics is still there.