Convert ember-debug to ESM and simplify wrapper#2672
Merged
ef4 merged 8 commits intoemberjs:mainfrom Jul 29, 2025
Merged
Conversation
NullVoxPopuli
approved these changes
Jul 28, 2025
RobbieTheWagner
approved these changes
Jul 29, 2025
Member
RobbieTheWagner
left a comment
RobbieTheWagner
left a comment
There was a problem hiding this comment.
Seems fine to me! I assume this is still compatible with our setup to check if you are on older Ember versions and load a totally different inspector?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the last of the refactors necessary before we can simply add Vite support. The two main changes in this PR:
ember-debugscript from ember-cli and making it 100% the job of Rollupember-debugscript using type=module now that it is ESMI have tested this locally and it works 🎉 I have also been very carful not to refactor the
startup-wrappercode, instead I've just split it out and moved the exact code around. This will give us the best chance that the code will work the same and any further improvements to the code can be made in separate PRs 👍