[DO NOT MERGE] the delta between main and what we're experimenting with that needs a bunch of RFCs first by NullVoxPopuli · Pull Request #20923 · emberjs/ember.js

NullVoxPopuli · 2025-06-10T21:04:37Z

This PR shows a strategy of working towards our goal of removing stuff from the framework we all know we don't want -- but uses the act of doing the work to help discover what needs to go in to an RFC, what order RFCs need to be in, and what blockers/dependencies are/could be.

Needed RFCs

[Next] Kill Evented

[Next] Kill ArrayProxy, ObjectProxy, and PromiseProxy

github-actions · 2025-06-10T21:14:12Z

Estimated Asset Sizes

Diff

--- main/out.txt	2025-06-17 19:22:58.000000000 +0000
+++ pr/./pr-15789135057/out.txt	2025-06-20 22:51:46.000000000 +0000
@@ -1,59 +1,59 @@
-╔═══════╤══════════╤═══════════╗
-║       │ Min      │ Gzip      ║
-╟───────┼──────────┼───────────╢
-║ Total │ 409.3 KB │ 228.73 KB ║
-╚═══════╧══════════╧═══════════╝
+╔═══════╤═══════════╤═══════════╗
+║       │ Min       │ Gzip      ║
+╟───────┼───────────┼───────────╢
+║ Total │ 379.36 KB │ 211.09 KB ║
+╚═══════╧═══════════╧═══════════╝
 
 ╔══════════════════════╤═══════════╤═══════════╗
 ║ @ember/*             │ Min       │ Gzip      ║
 ╟──────────────────────┼───────────┼───────────╢
-║ Total                │ 239.69 KB │ 147.05 KB ║
+║ Total                │ 209.75 KB │ 129.46 KB ║
 ╟──────────────────────┼───────────┼───────────╢
-║ -internals           │ 35.92 KB  │ 25.65 KB  ║
-║ application          │ 12.83 KB  │ 7.58 KB   ║
-║ array                │ 12.66 KB  │ 7.32 KB   ║
+║ -internals           │ 28.24 KB  │ 20.19 KB  ║
+║ application          │ 12.39 KB  │ 7.55 KB   ║
+║ array                │ 1.38 KB   │ 1.35 KB   ║
 ║ canary-features      │ 304 B     │ 405 B     ║
-║ component            │ 1.07 KB   │ 995 B     ║
-║ controller           │ 1.8 KB    │ 1.36 KB   ║
-║ debug                │ 11.4 KB   │ 7.87 KB   ║
+║ component            │ 1.07 KB   │ 967 B     ║
+║ controller           │ 1.25 KB   │ 1.11 KB   ║
+║ debug                │ 10.98 KB  │ 7.82 KB   ║
 ║ deprecated-features  │ 31 B      │ 77 B      ║
 ║ destroyable          │ 561 B     │ 383 B     ║
-║ enumerable           │ 259 B     │ 387 B     ║
-║ helper               │ 823 B     │ 615 B     ║
+║ enumerable           │ 0 B       │ 0 B       ║
+║ helper               │ 823 B     │ 595 B     ║
 ║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
-║ modifier             │ 669 B     │ 605 B     ║
-║ object               │ 33.78 KB  │ 20.82 KB  ║
+║ modifier             │ 669 B     │ 612 B     ║
+║ object               │ 26.43 KB  │ 15.9 KB   ║
 ║ owner                │ 159 B     │ 178 B     ║
 ║ renderer             │ 385 B     │ 344 B     ║
-║ routing              │ 58.05 KB  │ 33.12 KB  ║
-║ runloop              │ 2.2 KB    │ 1.41 KB   ║
-║ service              │ 859 B     │ 741 B     ║
-║ template             │ 396 B     │ 342 B     ║
+║ routing              │ 56.83 KB  │ 33.01 KB  ║
+║ runloop              │ 2.2 KB    │ 1.35 KB   ║
+║ service              │ 859 B     │ 740 B     ║
+║ template             │ 396 B     │ 340 B     ║
 ║ template-compilation │ 429 B     │ 366 B     ║
 ║ template-compiler    │ 57.81 KB  │ 30.44 KB  ║
 ║ template-factory     │ 94 B      │ 160 B     ║
 ║ test                 │ 923 B     │ 627 B     ║
-║ utils                │ 3.93 KB   │ 3.51 KB   ║
+║ utils                │ 3.17 KB   │ 3.19 KB   ║
 ║ version              │ 55 B      │ 131 B     ║
 ╚══════════════════════╧═══════════╧═══════════╝
 
 ╔═════════════════╤═══════════╤══════════╗
 ║ @glimmer/*      │ Min       │ Gzip     ║
 ╟─────────────────┼───────────┼──────────╢
-║ Total           │ 169.61 KB │ 81.69 KB ║
+║ Total           │ 169.61 KB │ 81.63 KB ║
 ╟─────────────────┼───────────┼──────────╢
 ║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
 ║ encoder         │ 596 B     │ 653 B    ║
 ║ env             │ 38 B      │ 87 B     ║
 ║ global-context  │ 886 B     │ 545 B    ║
-║ manager         │ 12.19 KB  │ 5.44 KB  ║
+║ manager         │ 12.19 KB  │ 5.41 KB  ║
 ║ node            │ 2.71 KB   │ 1.81 KB  ║
 ║ opcode-compiler │ 29.89 KB  │ 13.23 KB ║
 ║ owner           │ 159 B     │ 202 B    ║
 ║ program         │ 7.1 KB    │ 3.63 KB  ║
 ║ reference       │ 5.51 KB   │ 3.18 KB  ║
 ║ runtime         │ 95.26 KB  │ 42.51 KB ║
-║ tracking        │ 989 B     │ 972 B    ║
+║ tracking        │ 989 B     │ 944 B    ║
 ║ util            │ 3.03 KB   │ 2.29 KB  ║
 ║ validator       │ 6 KB      │ 3.72 KB  ║
 ║ vm              │ 784 B     │ 798 B    ║

Details

This PR main

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 379.36 KB │ 211.09 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 209.75 KB │ 129.46 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 28.24 KB  │ 20.19 KB  ║
║ application          │ 12.39 KB  │ 7.55 KB   ║
║ array                │ 1.38 KB   │ 1.35 KB   ║
║ canary-features      │ 304 B     │ 405 B     ║
║ component            │ 1.07 KB   │ 967 B     ║
║ controller           │ 1.25 KB   │ 1.11 KB   ║
║ debug                │ 10.98 KB  │ 7.82 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 0 B       │ 0 B       ║
║ helper               │ 823 B     │ 595 B     ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
║ modifier             │ 669 B     │ 612 B     ║
║ object               │ 26.43 KB  │ 15.9 KB   ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 385 B     │ 344 B     ║
║ routing              │ 56.83 KB  │ 33.01 KB  ║
║ runloop              │ 2.2 KB    │ 1.35 KB   ║
║ service              │ 859 B     │ 740 B     ║
║ template             │ 396 B     │ 340 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 57.81 KB  │ 30.44 KB  ║
║ template-factory     │ 94 B      │ 160 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 3.17 KB   │ 3.19 KB   ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤═══════════╤══════════╗
║ @glimmer/*      │ Min       │ Gzip     ║
╟─────────────────┼───────────┼──────────╢
║ Total           │ 169.61 KB │ 81.63 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
║ encoder         │ 596 B     │ 653 B    ║
║ env             │ 38 B      │ 87 B     ║
║ global-context  │ 886 B     │ 545 B    ║
║ manager         │ 12.19 KB  │ 5.41 KB  ║
║ node            │ 2.71 KB   │ 1.81 KB  ║
║ opcode-compiler │ 29.89 KB  │ 13.23 KB ║
║ owner           │ 159 B     │ 202 B    ║
║ program         │ 7.1 KB    │ 3.63 KB  ║
║ reference       │ 5.51 KB   │ 3.18 KB  ║
║ runtime         │ 95.26 KB  │ 42.51 KB ║
║ tracking        │ 989 B     │ 944 B    ║
║ util            │ 3.03 KB   │ 2.29 KB  ║
║ validator       │ 6 KB      │ 3.72 KB  ║
║ vm              │ 784 B     │ 798 B    ║
║ wire-format     │ 1.84 KB   │ 1.35 KB  ║
╚═════════════════╧═══════════╧══════════╝

╔═══════╤══════════╤═══════════╗
║       │ Min      │ Gzip      ║
╟───────┼──────────┼───────────╢
║ Total │ 409.3 KB │ 228.73 KB ║
╚═══════╧══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 239.69 KB │ 147.05 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 35.92 KB  │ 25.65 KB  ║
║ application          │ 12.83 KB  │ 7.58 KB   ║
║ array                │ 12.66 KB  │ 7.32 KB   ║
║ canary-features      │ 304 B     │ 405 B     ║
║ component            │ 1.07 KB   │ 995 B     ║
║ controller           │ 1.8 KB    │ 1.36 KB   ║
║ debug                │ 11.4 KB   │ 7.87 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 823 B     │ 615 B     ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
║ modifier             │ 669 B     │ 605 B     ║
║ object               │ 33.78 KB  │ 20.82 KB  ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 385 B     │ 344 B     ║
║ routing              │ 58.05 KB  │ 33.12 KB  ║
║ runloop              │ 2.2 KB    │ 1.41 KB   ║
║ service              │ 859 B     │ 741 B     ║
║ template             │ 396 B     │ 342 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 57.81 KB  │ 30.44 KB  ║
║ template-factory     │ 94 B      │ 160 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 3.93 KB   │ 3.51 KB   ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤═══════════╤══════════╗
║ @glimmer/*      │ Min       │ Gzip     ║
╟─────────────────┼───────────┼──────────╢
║ Total           │ 169.61 KB │ 81.69 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
║ encoder         │ 596 B     │ 653 B    ║
║ env             │ 38 B      │ 87 B     ║
║ global-context  │ 886 B     │ 545 B    ║
║ manager         │ 12.19 KB  │ 5.44 KB  ║
║ node            │ 2.71 KB   │ 1.81 KB  ║
║ opcode-compiler │ 29.89 KB  │ 13.23 KB ║
║ owner           │ 159 B     │ 202 B    ║
║ program         │ 7.1 KB    │ 3.63 KB  ║
║ reference       │ 5.51 KB   │ 3.18 KB  ║
║ runtime         │ 95.26 KB  │ 42.51 KB ║
║ tracking        │ 989 B     │ 972 B    ║
║ util            │ 3.03 KB   │ 2.29 KB  ║
║ validator       │ 6 KB      │ 3.72 KB  ║
║ vm              │ 784 B     │ 798 B    ║
║ wire-format     │ 1.84 KB   │ 1.35 KB  ║
╚═════════════════╧═══════════╧══════════╝

[Next] Kill Comparable

Kill view mixins

[Next] Kill Action Mixins

[Next] Kill array and proxy mixins

[Next] Kill even more mixins

Merge main in to next

Remove observable methods

Remove @ember/object/events

wagenet and others added 7 commits June 10, 2025 13:05

Run CI on next

f24d840

Merge remote-tracking branch 'origin/main' into next

2c64b52

Kill Evented

16e8ed7

Merge pull request #20917 from wagenet/kill-evented

9d26e9e

[Next] Kill Evented

Kill ArrayProxy, ObjectProxy, and PromiseProxy

03416b1

Merge pull request #20918 from wagenet/kill-proxy

14dd191

[Next] Kill ArrayProxy, ObjectProxy, and PromiseProxy

Kill Comparable

f388229

wagenet and others added 22 commits June 10, 2025 14:25

Merge pull request #20924 from wagenet/kill-comparable

c902478

[Next] Kill Comparable

Kill ChildViewsSupport mixin

e0e4332

Kill ClassNamesSupport

4b0041d

Kill ViewStateSupport mixin

75427e7

Kill ViewMixin

e3b123c

Fix TS 5.0

f0691a7

Merge pull request #20925 from wagenet/kill-view-mixins

f74a525

Kill view mixins

Kill ActionHandler mixin

e7291d5

Kill TargetActionSupport

a6760ec

Merge pull request #20919 from wagenet/kill-more-mixins

6d514d5

[Next] Kill Action Mixins

Kill Array mixins, some computed macros

1fa44dc

Kill ObservableMixin, EmberObject no longer uses mixins!

251eae8

Kill ControllerMixin

4c16999

Inline lifecycle methods

62fd793

Kill Enumerable

3e644c9

Kill ContainerProxyMixin

545f883

Merge pull request #20921 from wagenet/kill-array-mixins

e62120a

[Next] Kill array and proxy mixins

Kill RegistryProxy Mixin

990fb41

Merge remote-tracking branch 'origin/main' into next

c4ac932

Don't attempt to publish next branch to s3

5f6dc83

Merge pull request #20928 from emberjs/kill-even-more-mixins

ab874bc

[Next] Kill even more mixins

Merge pull request #20930 from emberjs/main

9b48198

wagenet and others added 11 commits June 13, 2025 08:26

Merge pull request #20934 from emberjs/main

362f70c

Merge main in to next

Remove global observer helper since it doesn't work with native classes

76b2480

Remove get/getProperties from EmberObject

b4d0519

Remove set/setProperties from EmberObject

414bdec

Remove property change methods from EmberObject

ed846b5

Remove observer methods from EmberObject - No more public observers!

61b6e00

Remove remaining property methods from EmberObject

096f7fe

Merge pull request #20937 from wagenet/remove-observable-methods

14bdd33

Remove observable methods

Merge remote-tracking branch 'origin/main' into next

42a0320

Remove @ember/object/events

2edb624

Merge pull request #20940 from wagenet/remove-ember-object-events

5c537ac

Remove @ember/object/events

NullVoxPopuli mentioned this pull request Jul 13, 2025

10-20% performance regression between 5.9 and 5.10 #20719

Closed

NullVoxPopuli mentioned this pull request Sep 7, 2025

Prototype what it would be like to remove the classic / pre-octane things from @ember/component #20972

Draft

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DO NOT MERGE] the delta between main and what we're experimenting with that needs a bunch of RFCs first#20923

[DO NOT MERGE] the delta between main and what we're experimenting with that needs a bunch of RFCs first#20923
NullVoxPopuli wants to merge 40 commits intomainfrom
next

NullVoxPopuli commented Jun 10, 2025 •

edited by wagenet

Loading

Uh oh!

github-actions bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

NullVoxPopuli commented Jun 10, 2025 • edited by wagenet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NullVoxPopuli commented Jun 10, 2025 •

edited by wagenet

Loading

github-actions bot commented Jun 10, 2025 •

edited

Loading