Origin should be (scheme, host, port) not (is_ssl, host, port)

[sethmlarson]

Example: http+unix//localhost and http://localhost would currently have the same origin despite being a different scheme. Change this by using URL.scheme instead of is_ssl.

[StephenBrown2]

It's an easy change, but what about this?

Could potentially just add .scheme and keep .is_ssl around as well:

class Origin:
    """
    The URL scheme and authority information, as a comparable, hashable object.
    """

    def __init__(self, url: URLTypes) -> None:
        if not isinstance(url, URL):
            url = URL(url)
        self.scheme = url.scheme
        self.is_ssl = url.is_ssl
        self.host = url.host
        self.port = url.port

    def __eq__(self, other: typing.Any) -> bool:
        return (
            isinstance(other, self.__class__)
            and self.scheme == other.scheme
            and self.host == other.host
            and self.port == other.port
        )

    def __hash__(self) -> int:
        return hash((self.scheme, self.host, self.port))

[sethmlarson]

Yeah we can keep the is_ssl parameter on the Origin class. Did you want to turn that mockup into a PR? :D

[StephenBrown2]

I was planning on it! :-)