added cov-fail-under=100 for pytest #206
Conversation
httpx/models.py
Outdated
| self._uri_reference = self._uri_reference.copy_with( | ||
| authority=idna_authority | ||
| ) | ||
| ) # pragma: nocover |
There was a problem hiding this comment.
Instead of disabling coverage here let's create a simple unit test for the branch.
There was a problem hiding this comment.
I couldn't find a test case because if I try to Unicode domain, I get this error: rfc3986.exceptions.InvalidAuthority: The authority (😁.de) is not valid.
Should we change this part if there is no case or could you help me with this?
There was a problem hiding this comment.
What about ουτοπία.δπθ.gr? Emojis aren't valid for IDNs for IDNA 2008.
There was a problem hiding this comment.
idna encode raises an error if there is any char that greater then 128. (it's not just about emoji link) so this if clause is never used. If you want we can delete this part with another PR and check InvalidAuthority error?
There was a problem hiding this comment.
I think we can literally just get rid of that whole if statement branch. IRIReference.encode() does everything for us. Tested it locally and it seems to work for me.
httpx/utils.py
Outdated
|
|
||
| if netrc_path is None: | ||
| return None | ||
| return None # pragma: nocover |
There was a problem hiding this comment.
Can we also create a unit test for here?
|
Thanks @cansarigol! |
2 participants
No description provided.