Skip to content

Conversation

@jtmiclat
Copy link
Contributor

@jtmiclat jtmiclat commented Aug 27, 2019

Based on the contribution document: https://github.com/encode/httpx/blob/master/docs/contributing.md

Users should be able to run test per file but using the following command

$ nox -s test -- tests/test_multipart.py

But running the command still runs all tests.

This PR allows the passing of single or multiple test files to run by using nox's posargs documented here: https://nox.thea.codes/en/stable/config.html#passing-arguments-into-sessions

@sethmlarson
Copy link
Contributor

I was just thinking about this too, you read my mind @jtmiclat! I simplified the PR just a little bit since posargs isn't necessarily just test files, can be options like -v as well. :)

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember I mentioned being able to run parts of the test suite in #239 (comment), so it’s a great improvement indeed! Thanks. 👍

@sethmlarson sethmlarson merged commit 1f4b8dd into encode:master Aug 27, 2019
jtmiclat added a commit to jtmiclat/httpx that referenced this pull request Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants