fix: resolve theme style inconsistency between CLI dashboard and docu…#12
Merged
fix: resolve theme style inconsistency between CLI dashboard and docu…#12
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR resolves a theme style inconsistency between the CLI dashboard and the documentation site by unifying them under the "Lyra" design system.
Changes:
- Updated CSS variables to use a new Lyra color palette that matches the documentation site theme
- Changed the default theme from "system" to "dark" in the dashboard
- Modified the build process to ensure dashboard assets are copied during CLI builds
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/webhook-cli/package.json | Bumped version to 3.4.3 and updated build:cli script to copy dashboard assets |
| apps/webhook-cli/CHANGELOG.md | Added changelog entry for version 3.4.3 documenting the theme alignment fix |
| apps/dashboard/src/index.css | Replaced oklch color scheme with Lyra palette-based CSS variables for both light and dark modes |
| apps/dashboard/src/App.tsx | Changed default theme from "system" to "dark" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Owner
Author
|
@greptile-apps review |
Owner
Author
|
@greptile-apps review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
This PR resolves theme style inconsistencies between the CLI dashboard and documentation site by adopting the "Lyra" design system. Key changes include:
Theme Changes:
Build Process Improvements:
copy-dashboard.mjsto run immediately after tsup inbuild:cliscriptcreateRequirewithreadFileSync+fileURLToPathfor reading package.json in ESM context (more explicit, works reliably with both CJS and ESM outputs)The changes ensure consistent branding across the CLI dashboard and documentation while maintaining the existing build workflow.
Confidence Score: 5/5
Important Files Changed
File Analysis
Sequence Diagram
sequenceDiagram participant User participant BuildScript as build script participant Dashboard as @better-webhook/dashboard participant Tsup as tsup (CLI build) participant CopyScript as copy-dashboard.mjs participant DistFolder as dist/ User->>BuildScript: pnpm run build BuildScript->>Dashboard: pnpm --filter @better-webhook/dashboard build Dashboard->>Dashboard: Build React dashboard Dashboard-->>DistFolder: apps/dashboard/dist/* BuildScript->>BuildScript: pnpm run build:cli BuildScript->>Tsup: tsup --format cjs,esm --dts Tsup->>Tsup: Compile TypeScript sources Note over Tsup: clean: false preserves existing dist Tsup-->>DistFolder: dist/index.js, dist/index.cjs, dist/*.d.ts BuildScript->>CopyScript: node ./scripts/copy-dashboard.mjs CopyScript->>CopyScript: Check if apps/dashboard/dist exists alt Dashboard built CopyScript->>DistFolder: Copy apps/dashboard/dist → dist/dashboard CopyScript-->>BuildScript: Exit 0 (success) else Dashboard not built CopyScript->>CopyScript: console.warn (skip copy) CopyScript-->>BuildScript: Exit 0 (graceful) end BuildScript-->>User: Build complete Note over User,DistFolder: Runtime: CLI serves dashboard from dist/dashboard User->>User: better-webhook dashboard User->>DistFolder: Load dist/index.js DistFolder->>DistFolder: Serve static files from dist/dashboard DistFolder-->>User: Dashboard UI with Lyra theme