[macOS] fix #106#187
Draft
whymidnight wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Hi, thank you for your PR. I don't have a mac to test this with right now. It probably will take a few weeks before I borrow one again. Merging this PR might take some time unfortunately. |
Author
|
i've converted this to a draft pr as i noticed key repeat stopped working for all keys. i will submit for review again once i fix this. |
Collaborator
|
Key repeat was always broken on macOS. See #98. I changed the code a lot, so the PR cannot get merged. I'll have a look at the issue in a few weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gm all,
this pr addresses #106 where
Key::Layout('$')gets typed as4. there appears a few resolutions though my approach was to useevent.set_string(&char.to_string()). this resolution however doesn't permit key repeat so untilself.key_to_keycode()resolvesis_ascii_punctuationforKey::Layout(char), this is a good intermediary.best
dom