Skip to content

ENG-4886 As a user that only visualizes a Virtual Tree, that can only manage pages of group free, I MUST be able to change around the order of pages even if there are siblings that are hidden to me.#164

Merged
entgigi merged 1 commit into
developfrom
ENG-4886_As-a-user-that-only-visualizes-a-Virtual-Tree-that-can-only-manage-pages-of-group-free-I-MUST-be-able-to-change-around-the-order
Jun 1, 2023
Merged

ENG-4886 As a user that only visualizes a Virtual Tree, that can only manage pages of group free, I MUST be able to change around the order of pages even if there are siblings that are hidden to me.#164
entgigi merged 1 commit into
developfrom
ENG-4886_As-a-user-that-only-visualizes-a-Virtual-Tree-that-can-only-manage-pages-of-group-free-I-MUST-be-able-to-change-around-the-order

Conversation

@entgigi
Copy link
Copy Markdown
Contributor

@entgigi entgigi commented May 30, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

Requested publication of version 7.3.0-ENG-4886-PR-164

2 similar comments
@github-actions
Copy link
Copy Markdown

Requested publication of version 7.3.0-ENG-4886-PR-164

@github-actions
Copy link
Copy Markdown

Requested publication of version 7.3.0-ENG-4886-PR-164

@entgigi entgigi requested review from eugeniosant and gp-ent May 31, 2023 10:57
@github-actions
Copy link
Copy Markdown

Requested publication of version 7.3.0-ENG-4886-PR-164

Copy link
Copy Markdown
Contributor

@eugeniosant eugeniosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@entgigi Looking at the code related to the proposed solution, you need the absolute position of the page corresponding to the relative position (user view) that you receive from the API call.
So, given the relative position of the page to move, you just need to retrieve the list of allowed nodes (method that already exists), take the node at the relative position specified (by the index into the list) and extract from this node the absolute position; this way you don't have to add any fields into TreeNode.

@entgigi entgigi force-pushed the ENG-4886_As-a-user-that-only-visualizes-a-Virtual-Tree-that-can-only-manage-pages-of-group-free-I-MUST-be-able-to-change-around-the-order branch from 5c7fa9c to c1675a5 Compare May 31, 2023 15:46
@entgigi entgigi requested a review from eugeniosant May 31, 2023 15:48
@github-actions
Copy link
Copy Markdown

Requested publication of version 7.3.0-ENG-4886-PR-164

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Copy Markdown

Requested publication of version 7.3.0-ENG-4886-PR-164

@entgigi entgigi merged commit 45e059e into develop Jun 1, 2023
@eugeniosant eugeniosant deleted the ENG-4886_As-a-user-that-only-visualizes-a-Virtual-Tree-that-can-only-manage-pages-of-group-free-I-MUST-be-able-to-change-around-the-order branch September 1, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants