Skip to content

ENG-5082: Fix bug uninstallation of complex bundle#197

Merged
mirkoPan merged 2 commits into
developfrom
ENG-5082
Aug 3, 2023
Merged

ENG-5082: Fix bug uninstallation of complex bundle#197
mirkoPan merged 2 commits into
developfrom
ENG-5082

Conversation

@eugeniosant
Copy link
Copy Markdown
Contributor

@eugeniosant eugeniosant commented Jul 31, 2023

No description provided.

@eugeniosant eugeniosant requested a review from mirkoPan July 31, 2023 16:08
@eugeniosant eugeniosant marked this pull request as draft July 31, 2023 16:08
@eugeniosant eugeniosant requested a review from entgigi July 31, 2023 16:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 31, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 1, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

@eugeniosant eugeniosant marked this pull request as ready for review August 1, 2023 08:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 1, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 1, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 1, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

mirkoPan
mirkoPan approved these changes Aug 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mirkoPan mirkoPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

entgigi
entgigi suggested changes Aug 2, 2023
View reviewed changes
Comment thread ...c/main/java/org/entando/entando/aps/system/services/component/ComponentDeleteRequestRow.java Outdated
Comment thread engine/src/main/java/org/entando/entando/aps/system/services/component/ComponentService.java
Comment thread .../src/main/java/org/entando/entando/aps/system/services/component/IComponentUsageService.java
Comment thread engine/src/main/java/org/entando/entando/aps/system/services/page/PageService.java Outdated
Comment thread ...ain/java/com/agiletec/plugins/jpversioning/aps/system/services/versioning/VersioningDAO.java
@eugeniosant eugeniosant requested a review from entgigi August 2, 2023 15:42
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 2, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 2, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

entgigi
entgigi approved these changes Aug 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@entgigi entgigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirkoPan mirkoPan merged commit f7d35d9 into develop Aug 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 3, 2023

Requested publication of version 7.3.0-ENG-5082-PR-197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mirkoPan mirkoPan mirkoPan approved these changes

@entgigi entgigi entgigi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eugeniosant @mirkoPan @entgigi