Skip to content

ENG-5051 Error removing Asset#228

Merged
mirkoPan merged 5 commits into
release/7.3from
ENG-5051
Oct 31, 2023
Merged

ENG-5051 Error removing Asset#228
mirkoPan merged 5 commits into
release/7.3from
ENG-5051

Conversation

@mirkoPan
Copy link
Copy Markdown
Contributor

@mirkoPan mirkoPan commented Oct 23, 2023

No description provided.

@mirkoPan mirkoPan requested a review from eugeniosant October 23, 2023 16:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 24, 2023

Requested publication of version 7.3.0-ENG-5051-PR-228

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 24, 2023

Requested publication of version 7.3.0-ENG-5051-PR-228

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 24, 2023

Requested publication of version 7.3.0-ENG-5051-PR-228

eugeniosant
eugeniosant suggested changes Oct 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@eugeniosant eugeniosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two new exception classes are specific fore CDS component; Can you include them in the CDS sub-project? package org.entando.entando.plugins.jpcds.aps.system.exception. Thanks

@mirkoPan
Copy link
Copy Markdown
Contributor Author

mirkoPan commented Oct 26, 2023

The two new exception classes are specific fore CDS component; Can you include them in the CDS sub-project? package org.entando.entando.plugins.jpcds.aps.system.exception. Thanks

given the division into modules, moving the exceptions to the CDS-related module is unfortunately not possible. The jointly agreed solution applied was renaming the exceptions by removing the CDS prefix so that they can in the future be used for other resource-related flows as well

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 26, 2023

Requested publication of version 7.3.0-ENG-5051-PR-228

@mirkoPan mirkoPan requested a review from eugeniosant October 26, 2023 14:32
@mirkoPan mirkoPan merged commit 800295d into release/7.3 Oct 31, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 31, 2023

Requested publication of version 7.3.0-ENG-5051-PR-228

@eugeniosant eugeniosant deleted the ENG-5051 branch November 6, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eugeniosant eugeniosant eugeniosant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mirkoPan @eugeniosant