fix: sort solver candidates by parsed merged_at, not raw ISO string#882
Closed
since-2017-hub wants to merge 1 commit into
Closed
fix: sort solver candidates by parsed merged_at, not raw ISO string#882since-2017-hub wants to merge 1 commit into
since-2017-hub wants to merge 1 commit into
Conversation
… ISO precision find_solver_from_cross_references sorted candidate closing PRs by raw ISO 8601 strings, which only sorts correctly when every value uses the same precision and timezone suffix. GitHub's GraphQL has historically returned both '...:00Z' and '...:00.000Z' shapes; lexicographically '.000Z' < 'Z', so a sub-second-precision PR sorts earlier than a second-precision one at the same instant and steals solver attribution from the deterministic pr.number tiebreaker. Parse merged_at via parse_github_iso_to_utc (already imported) before sorting, with datetime.min(UTC) as a defensive fallback for missing values.
Collaborator
|
GraphQL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #881
Summary
find_solver_from_cross_referencesdecides which merged PR is creditedas an issue's solver by sorting candidates by
merged_atascending,with
pr.numberas a deterministic tiebreaker. The sort key was theraw ISO 8601 string returned by GraphQL: