fix: split the ext proc config to avoid k8s size limits#1865
Open
zhaohuabing wants to merge 5 commits intoenvoyproxy:mainfrom
Open
fix: split the ext proc config to avoid k8s size limits#1865zhaohuabing wants to merge 5 commits intoenvoyproxy:mainfrom
zhaohuabing wants to merge 5 commits intoenvoyproxy:mainfrom
Conversation
13c7179 to
c501d69
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
==========================================
+ Coverage 83.71% 84.23% +0.52%
==========================================
Files 126 131 +5
Lines 16657 17786 +1129
==========================================
+ Hits 13944 14982 +1038
- Misses 1811 1856 +45
- Partials 902 948 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
319dd49 to
fcf54fc
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> refactor Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> polish code Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
04c3931 to
981d8cb
Compare
nacx
reviewed
Feb 25, 2026
Member
nacx
left a comment
There was a problem hiding this comment.
Overall, it looks good.
So the summary of the PR is that:
- It will split the secret if it exceeds the max object k8s size, and split to a max of 8 chunks (for now).
- If there is no size overflow, empty chunks up to the 8 max ones will be created to avoid having to remount and cycle the pod.
- The extproc receives a new parameter,
-configBundlePath, that if present will start the new watcher to watch for the new chunked config.
If this understanding is OK :) I have a few questions:
- Can we avoid creating the empty chunks? We could still add the volumes and secret projections to the pod, but mark those
optional? Would that work to avoid having to create the empty secrets? - The controller will pass the new arg
-configBundlePathto the extproc if it finds the "index" secret. That secret is always created now, correct?- Could we provide a way to opt-in to this new feature, so that the controller does not create this secret (and extproc does not instantiate the new watchers, etc, etc)? This is quite a sensitive feature, and it would be great to have an option to explicitly opt-in.
Thanks for this PR!
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the ext proc/mcpproxy config into multiple secrets, so it can bypass the k8s size limits.
Related Issues/PRs (if applicable)
Fixes #1613
cc @nacx