docs: extract and validate k8s resources#1973
Draft
herewasmike wants to merge 2 commits intoenvoyproxy:mainfrom
Draft
docs: extract and validate k8s resources#1973herewasmike wants to merge 2 commits intoenvoyproxy:mainfrom
herewasmike wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Mikhail Toldov <matoldov@gmail.com>
Signed-off-by: Mikhail Toldov <matoldov@gmail.com>
8f5ada0 to
dcc83ff
Compare
Contributor
Author
|
@missBerg what are your thoughts on this approach? (I'll address migration to v1beta later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move embedded yaml from docs to separate files.
Validate them (and examples folder) with kubeconform
Special notes for reviewers (if applicable)
Not sure if we're fine with network calls to get schemas (from https://github.com/yannh/kubernetes-json-schema) for resources defined outside of this repo.
This is still wip and I want to get some feedback on the approach