feat(gcp): add GKE Workload Identity support via Application Default Credentials#1979
Open
rajatvig wants to merge 3 commits intoenvoyproxy:mainfrom
Open
feat(gcp): add GKE Workload Identity support via Application Default Credentials#1979rajatvig wants to merge 3 commits intoenvoyproxy:mainfrom
rajatvig wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
…Credentials Allow GCP credentials to use ADC when neither credentialsFile nor workloadIdentityFederationConfig is specified. This enables GKE Workload Identity without additional configuration, matching the AWS IRSA/Pod Identity pattern. The extproc now uses google.FindDefaultCredentials() to obtain tokens dynamically, eliminating the need for controller-side token rotation. Signed-off-by: Rajat Vig <rvig@etsy.com>
|
Related Documentation 3 document(s) may need updating based on files changed in this PR: Envoy's Space connect-providers
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 84.33% 84.35% +0.01%
==========================================
Files 130 130
Lines 17986 18008 +22
==========================================
+ Hits 15169 15190 +21
- Misses 1873 1874 +1
Partials 944 944 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rajat Vig <rvig@etsy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for GKE Workload Identity via Application Default Credentials (ADC).
When neither
credentialsFilenorworkloadIdentityFederationConfigis specifiedin
BackendSecurityPolicyGCPCredentials, the extproc now uses ADC to obtain tokensdynamically. This enables GKE Workload Identity without additional configuration,
matching the existing AWS IRSA/Pod Identity pattern.
Related Issues/PRs (if applicable)
Special notes for reviewers (if applicable)
This PR was developed with AI assistance (Claude). All changes were reviewed by human.