Open
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
=======================================
Coverage 84.33% 84.33%
=======================================
Files 130 130
Lines 17987 17987
=======================================
Hits 15170 15170
Misses 1873 1873
Partials 944 944 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
/retest |
Contributor
|
@mathetake Do we have any credentials/ev that need to be rotated? I see that we are using a pinned trivy image. Is it better to take actions from our side(if any) than to remove it ? What do you think? |
Member
Author
Yes |
Member
Author
|
And no I have no alternative and I don't have a confidence that the pinned action is safe either at this point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe we are not affected but it's too dangerous to rely on it anymroe aquasecurity/trivy#10425