dynamic_modules: add dynamic modules support for upstream#43703
Open
agrawroh wants to merge 1 commit intoenvoyproxy:mainfrom
Open
dynamic_modules: add dynamic modules support for upstream#43703agrawroh wants to merge 1 commit intoenvoyproxy:mainfrom
agrawroh wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
agrawroh
force-pushed
the
feat-dm-upst
branch
6 times, most recently
from
7ed9ffc to
d1d8d52
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
| source/extensions/transport_sockets/proxy_protocol: 96.2 | ||
| source/extensions/transport_sockets/tls/cert_mappers/filter_state_override: 96.2 | ||
| source/extensions/transport_sockets/tls/cert_validator/spiffe: 96.2 | ||
| source/extensions/upstreams/http/dynamic_modules: 96.2 |
Contributor
There was a problem hiding this comment.
Any chance we can add more tests to increase coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for writing new upstream extensions using Dynamic Modules.
Commit Message: dynamic_modules: add dynamic modules support for upstream extensions
Additional Description: Adds support for writing new upstream extensions using Dynamic Modules.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added