fix: Survey crash caused by fully answered survey#1273
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the SurveyProvider when the backend returns a survey where all questions are already answered, which previously resulted in activeQuestionIndex being set to -1 and downstream indexing errors.
Changes:
- Clamp the initially computed question index to
0when no unanswered question is found. - Add tests covering “all answered” and “some answered” initialization cases.
- Bump package version from
12.0.3to12.0.4.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/providers/SurveyProvider/SurveyProvider.tsx | Prevents activeQuestionIndex from being initialized to -1 when all questions are answered. |
| src/providers/SurveyProvider/SurveyProvider.test.tsx | Adds regression coverage for the initialization behavior with answered/unanswered question sets. |
| package.json | Patch version bump for the fix release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a survey's questions were all answered (which shouldn't really happen, but backend is sending answered surveys atm) the survey provider would cause a crash because activeQuestionIndex was being set to -1