refactor: encapsulate oracle config access via getter methods#334
Merged
Alesfatalis merged 3 commits intodevelopfrom Sep 27, 2025
Merged
refactor: encapsulate oracle config access via getter methods#334Alesfatalis merged 3 commits intodevelopfrom
Alesfatalis merged 3 commits intodevelopfrom
Conversation
- Add getter methods for oracle_address, oracle_mnemonic, change_address, and network_prefix - Prefer reading oracle_mnemonic from env vars or oracle-config file - Replace direct field access with getter methods throughout the codebase - Remove unnecessary address cloning and unwrapping - Improve encapsulation and enable more secure config handling
Pull Request Test Coverage Report for Build 15366130552Details
💛 - Coveralls |
kushti
approved these changes
May 31, 2025
Alesfatalis
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #333
Breaking Change:
Oracle operators must now add
oracle_network: mainnetto theiroracle_config.yamlfile.The
oracle_addressfield is no longer required and can be removed.Secret Loading Priority:
The application now loads the oracle's secret or mnemonic using the following priority:
ORACLE_WALLET_SECRET(hex format) from environment variablesoracle_secretfromoracle_config.yamlORACLE_WALLET_MNEMONICfrom environment variablesoracle_mnemonicfromoracle_config.yaml