execution/execmodule: fix unwinding logic when side forks go back in height#18993
Merged
Conversation
AskAlexSharov
approved these changes
Feb 6, 2026
Giulio2002
pushed a commit
that referenced
this pull request
Feb 6, 2026
…height (#18993) This was caught by some of the gas-benchmark tests which run a series of new payloads and FCUs for forks with different heights, and they jump from one fork to another. The issue was that we were not calling `TruncateCanonicalHash` for heights after the new FCU head number. Which meant that `AppendCanonicalTxNums` was appending more txNums than it should for the given FCU fork (i.e. it was going beyond it) if the fork before it was longer in height. This messed up the txNums index and caused wrong trie roots.
Member
|
@taratorio shall we port this to |
taratorio
added a commit
that referenced
this pull request
Feb 10, 2026
…height (#18993) This was caught by some of the gas-benchmark tests which run a series of new payloads and FCUs for forks with different heights, and they jump from one fork to another. The issue was that we were not calling `TruncateCanonicalHash` for heights after the new FCU head number. Which meant that `AppendCanonicalTxNums` was appending more txNums than it should for the given FCU fork (i.e. it was going beyond it) if the fork before it was longer in height. This messed up the txNums index and caused wrong trie roots.
Member
Author
|
AskAlexSharov
pushed a commit
that referenced
this pull request
Feb 10, 2026
…ck in height (#18993) (#19063) cherry-pick: #18993 --- This was caught by some of the gas-benchmark tests which run a series of new payloads and FCUs for forks with different heights, and they jump from one fork to another. The issue was that we were not calling `TruncateCanonicalHash` for heights after the new FCU head number. Which meant that `AppendCanonicalTxNums` was appending more txNums than it should for the given FCU fork (i.e. it was going beyond it) if the fork before it was longer in height. This messed up the txNums index and caused wrong trie roots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was caught by some of the gas-benchmark tests which run a series of new payloads and FCUs for forks with different heights, and they jump from one fork to another.
The issue was that we were not calling
TruncateCanonicalHashfor heights after the new FCU head number. Which meant thatAppendCanonicalTxNumswas appending more txNums than it should for the given FCU fork (i.e. it was going beyond it) if the fork before it was longer in height. This messed up the txNums index and caused wrong trie roots.