Skip to content

node, cmd, execution: remove Silkworm integration#19662

Merged
AskAlexSharov merged 2 commits into
mainfrom
canepat/remove_silkworm_integration
Mar 6, 2026
Merged

node, cmd, execution: remove Silkworm integration#19662
AskAlexSharov merged 2 commits into
mainfrom
canepat/remove_silkworm_integration

Conversation

@canepat

@canepat canepat commented Mar 5, 2026

Copy link
Copy Markdown
Member

Remove the embedded Silkworm C++ execution engine support entirely. This removes all --silkworm.* CLI flags, config fields, initialization and lifecycle code, build system hooks, and the silkworm-go dependency.

Closes #19403

Remove the embedded Silkworm C++ execution engine support entirely.
This removes all --silkworm.* CLI flags, config fields, initialization
and lifecycle code, build system hooks, and the silkworm-go dependency.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Giulio2002

Copy link
Copy Markdown
Contributor

[SharovBot] Same intermittent Go 1.26.0 Windows crash as tracked in #19640 / golang/go#77955.

CI uses go-version: '>=1.25' which picks up Go 1.26.0 from the runner tool cache (regardless of toolchain go1.25.7 in go.mod with GOTOOLCHAIN=local). Go 1.26.0 has an intermittent ACCESS_VIOLATION in runtime.(*unwinder).next during GC stack shrink in p2p/discover.

Fix is pending in #19640. Once that merges, you can rebase.

@AskAlexSharov AskAlexSharov enabled auto-merge (squash) March 6, 2026 06:55
@AskAlexSharov AskAlexSharov merged commit d3bdd9f into main Mar 6, 2026
27 checks passed
@AskAlexSharov AskAlexSharov deleted the canepat/remove_silkworm_integration branch March 6, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Silkworm support from codebase

4 participants