Skip to content

[r3.4] SpawnStageHistoryDownload: didn't support graceful restart#20766

Merged
AskAlexSharov merged 1 commit into
release/3.4from
alex/caplin_history_ctx_34
Apr 24, 2026
Merged

[r3.4] SpawnStageHistoryDownload: didn't support graceful restart#20766
AskAlexSharov merged 1 commit into
release/3.4from
alex/caplin_history_ctx_34

Conversation

@AskAlexSharov

Copy link
Copy Markdown
Collaborator

SpawnStageHistoryDownload was called with context.Background() instead of the stage's ctx, so Ctrl+C during history download was ignored — the process wouldn't exit gracefully until the download finished.

@AskAlexSharov AskAlexSharov changed the title [r3.4] cl: fix SpawnStageHistoryDownload ignoring context [r3.4] SpawnStageHistoryDownload: didn't support graceful restart Apr 24, 2026
@AskAlexSharov AskAlexSharov enabled auto-merge (squash) April 24, 2026 02:33
@AskAlexSharov AskAlexSharov requested a review from JkLondon April 24, 2026 09:04
@AskAlexSharov AskAlexSharov merged commit c8ae488 into release/3.4 Apr 24, 2026
21 checks passed
@AskAlexSharov AskAlexSharov deleted the alex/caplin_history_ctx_34 branch April 24, 2026 09:49
AskAlexSharov added a commit to Sahil-4555/erigon that referenced this pull request Apr 28, 2026
Cherry-picks of PRs from release/3.4 that were missing from main.

- erigontech#20778 rpc/mcp: fix tools/call hanging indefinitely under DB load
- erigontech#20775 tracing: fix prestateTracer diff mode missing deleted accounts
(flaky)
- erigontech#20766 SpawnStageHistoryDownload: didn't support graceful restart
- erigontech#20659 cl: move stats logging outside of mutex

---------

Co-authored-by: bloxster <40316187+bloxster@users.noreply.github.com>
Co-authored-by: Bloxster <bloxster@proton.me>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: lupin012 <58134934+lupin012@users.noreply.github.com>
Co-authored-by: info@weblogix.biz <admin@10gbps.weblogix.it>
lupin012 added a commit that referenced this pull request May 2, 2026
Cherry-picks of PRs from release/3.4 that were missing from main.

- #20778 rpc/mcp: fix tools/call hanging indefinitely under DB load
- #20775 tracing: fix prestateTracer diff mode missing deleted accounts
(flaky)
- #20766 SpawnStageHistoryDownload: didn't support graceful restart
- #20659 cl: move stats logging outside of mutex

---------

Co-authored-by: bloxster <40316187+bloxster@users.noreply.github.com>
Co-authored-by: Bloxster <bloxster@proton.me>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: lupin012 <58134934+lupin012@users.noreply.github.com>
Co-authored-by: info@weblogix.biz <admin@10gbps.weblogix.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants